New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-45629][CORE][SQL][CONNECT][ML][STREAMING][BUILD][EXAMPLES]Fix Implicit definition should have explicit type
#43526
Changes from all commits
ade4062
712b623
57992ca
06de84b
070e1b1
6bddb9e
39e88c4
39bf918
5e7cd26
38ca094
057e20e
dc035bb
da90c75
0d6d834
557a4d4
c771a88
7e7bf8e
cd35fe4
bafe785
b655d8c
e60fc0c
efefd0e
890ce70
9114019
8479852
40b7a74
3e391bc
7d2ca49
3f18a3e
995c82e
7c4bb5d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -30,6 +30,7 @@ import scala.concurrent.ExecutionContext.Implicits.global | |
import scala.concurrent.duration._ | ||
import scala.sys.process._ | ||
|
||
import org.json4s.Formats | ||
import org.json4s.jackson.JsonMethods | ||
|
||
import org.apache.spark.{SparkConf, SparkContext} | ||
|
@@ -340,7 +341,7 @@ private object FaultToleranceTest extends App with Logging { | |
private class TestMasterInfo(val ip: String, val dockerId: DockerId, val logFile: File) | ||
extends Logging { | ||
|
||
implicit val formats = org.json4s.DefaultFormats | ||
implicit val formats: Formats = org.json4s.DefaultFormats | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Although this seems correct, there is no mechanism to guarantee the correctness and availability of this file. |
||
var state: RecoveryState.Value = _ | ||
var liveWorkerIPs: List[String] = _ | ||
var numLiveApps = 0 | ||
|
@@ -383,7 +384,7 @@ private class TestMasterInfo(val ip: String, val dockerId: DockerId, val logFile | |
private class TestWorkerInfo(val ip: String, val dockerId: DockerId, val logFile: File) | ||
extends Logging { | ||
|
||
implicit val formats = org.json4s.DefaultFormats | ||
implicit val formats: Formats = org.json4s.DefaultFormats | ||
|
||
logDebug("Created worker: " + this) | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,7 +17,7 @@ | |
package org.apache.spark.examples.sql | ||
|
||
// $example on:programmatic_schema$ | ||
import org.apache.spark.sql.Row | ||
import org.apache.spark.sql.{Encoder, Row} | ||
// $example off:programmatic_schema$ | ||
// $example on:init_session$ | ||
import org.apache.spark.sql.SparkSession | ||
|
@@ -220,7 +220,8 @@ object SparkSQLExample { | |
// +------------+ | ||
|
||
// No pre-defined encoders for Dataset[Map[K,V]], define explicitly | ||
implicit val mapEncoder = org.apache.spark.sql.Encoders.kryo[Map[String, Any]] | ||
implicit val mapEncoder: Encoder[Map[String, Any]] = | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For the modifications to the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. done |
||
org.apache.spark.sql.Encoders.kryo[Map[String, Any]] | ||
// Primitive types and case classes can be also defined as | ||
// implicit val stringIntMapEncoder: Encoder[Map[String, Any]] = ExpressionEncoder() | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FaultToleranceTest
is a strange file, it's a test class, but it's in the production directory (so it probably has never been run by GA task). Can we directly delete this file? @srowen @dongjoon-hyun @HyukjinKwon