[SPARK-45664][SQL] Introduce a mapper for orc compression codecs #43528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beliefer
force-pushed
the
SPARK-45664
branch
2 times, most recently
from
44f3030
to
b349200
Compare
|
ping @dongjoon-hyun cc @srowen @viirya |
beliefer
force-pushed
the
SPARK-45664
branch
2 times, most recently
from
00b7b83
to
655fbeb
Compare
Because orc supported compression codecs and spark supported are not completely one-on-one due to Spark introduce two compression codecs I'm doing the same things for Parquet and Avro at Apache Spark 4.0.0. |
beliefer
force-pushed
the
SPARK-45664
branch
2 times, most recently
from
3258d65
to
a1b8ddd
Compare
dongjoon-hyun
approved these changes
Oct 30, 2023
|
@dongjoon-hyun Thank you! |
dongjoon-hyun
pushed a commit
that referenced
this pull request
Oct 31, 2023
…rings copy from parquet|orc|avro compression codes ### What changes were proposed in this pull request? This PR follows up #43562, #43528 and #43308. The aim of this PR is to avoid magic strings copy from `parquet|orc|avro` compression codes. This PR also simplify some test cases. ### Why are the changes needed? Avoid magic strings copy from parquet|orc|avro compression codes ### Does this PR introduce _any_ user-facing change? 'No'. ### How was this patch tested? Exists test cases. ### Was this patch authored or co-authored using generative AI tooling? 'No'. Closes #43604 from beliefer/parquet_orc_avro. Authored-by: Jiaan Geng <beliefer@163.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently, Spark supported all the orc compression codecs, but the orc supported compression codecs and spark supported are not completely one-on-one due to Spark introduce two compression codecs
NONEandUNCOMPRESSED.On the other hand, there are a lot of magic strings copy from orc compression codecs. This issue lead to developers need to manually maintain its consistency. It is easy to make mistakes and reduce development efficiency.
Why are the changes needed?
Let developers easy to use orc compression codecs.
Does this PR introduce any user-facing change?
'No'.
Introduce a new class.
How was this patch tested?
Exists test cases.
Was this patch authored or co-authored using generative AI tooling?
'No'.