[SPARK-43380][SQL] Fix slowdown in Avro read #43530
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR description mentions #42503 causes the performance regression, while the 42503 itself is a fix to another perf regression. I think we need some careful review here. |
|
@cloud-fan Could you help review given that you reviewed the #42503 that this PR is trying to fix |
cloud-fan
reviewed
Oct 26, 2023
connector/avro/src/main/scala/org/apache/spark/sql/avro/SchemaConverters.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Oct 26, 2023
connector/avro/src/main/scala/org/apache/spark/sql/avro/SchemaConverters.scala
Show resolved
Hide resolved
beliefer
reviewed
Oct 26, 2023
connector/avro/src/main/scala/org/apache/spark/sql/avro/SchemaConverters.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Oct 27, 2023
connector/avro/src/main/scala/org/apache/spark/sql/avro/SchemaConverters.scala
Outdated
Show resolved
Hide resolved
…Converters.scala Co-authored-by: Wenchen Fan <cloud0fan@gmail.com>
cloud-fan
reviewed
Oct 27, 2023
connector/avro/src/main/scala/org/apache/spark/sql/avro/SchemaConverters.scala
Show resolved
Hide resolved
cloud-fan
reviewed
Oct 27, 2023
cloud-fan
approved these changes
Oct 27, 2023
|
All tests passed. Should be good to merge @cloud-fan. |
|
thanks, merging to master/3.5! |
cloud-fan
pushed a commit
that referenced
this pull request
Oct 27, 2023
### What changes were proposed in this pull request? Fix slowdown in Avro read. There is a #42503 causes the performance regression. It seems that creating an `AvroOptions` inside `toSqlType` is very expensive. Try to pass this in the callstack. After regression  Before regression  ### Why are the changes needed? Need to fix the performance regression of Avro read. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Existing UT test ### Was this patch authored or co-authored using generative AI tooling? No Closes #43530 from zeruibao/SPARK-4380-real-fix-regression-2. Lead-authored-by: zeruibao <zerui.bao@databricks.com> Co-authored-by: Zerui Bao <125398515+zeruibao@users.noreply.github.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com> (cherry picked from commit 7d94c57) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
beliefer
added a commit
that referenced
this pull request
Oct 30, 2023
……useStableIdForUnionType: Boolean): SchemaType ### What changes were proposed in this pull request? #43530 provides a new method: ``` /** * Converts an Avro schema to a corresponding Spark SQL schema. * * since 4.0.0 */ def toSqlType(avroSchema: Schema, useStableIdForUnionType: Boolean): SchemaType = { toSqlTypeHelper(avroSchema, Set.empty, useStableIdForUnionType) } ``` Because take `AvroOptions` as parameter causes the performance regression, the old `toSqlType` looks very useless. This PR also improve some caller of `toSqlType` by pass `useStableIdForUnionType` directly. ### Why are the changes needed? Deprecate toSqlType(avroSchema: Schema, …useStableIdForUnionType: Boolean): SchemaType ### Does this PR introduce _any_ user-facing change? 'No'. ### How was this patch tested? Exists test cases. ### Was this patch authored or co-authored using generative AI tooling? 'No'. Closes #43557 from beliefer/SPARK-43380_followup. Authored-by: Jiaan Geng <beliefer@163.com> Signed-off-by: Jiaan Geng <beliefer@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix slowdown in Avro read. There is a #42503 causes the performance regression. It seems that creating an
AvroOptionsinsidetoSqlTypeis very expensive. Try to pass this in the callstack.After regression
Before regression
Why are the changes needed?
Need to fix the performance regression of Avro read.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing UT test
Was this patch authored or co-authored using generative AI tooling?
No