[SPARK-38723][SS][TEST][FOLLOWUP] Deflake the newly added test in QueryExecutionErrorsSuite #43565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @HeartSaVioR |
|
@HyukjinKwon Also the test should have failed in previous CI. In the checkError method we check if parameters match when the exception has parameter So it should have thrown as: The first is the parameter in the error itself, the second is empty because previously no parameter was passed in that checkError. So it should have been checked out in CI. Could this be a build issue (like the test wasn't ran at all..? |
MaxGekk
reviewed
Oct 30, 2023
Comment on lines
917
to
926
| exceptions.map { e => | ||
| if (e.isDefined) { | ||
| checkError( | ||
| e.get, | ||
| errorClass = "CONCURRENT_QUERY", | ||
| sqlState = Some("0A000") | ||
| sqlState = Some("0A000"), | ||
| parameters = e.get.getMessageParameters.asScala.toMap | ||
| ) | ||
| } | ||
| } |
There was a problem hiding this comment.
Could you simplify this?
exceptions.flatten.foreach { e =>
checkError(
e,
errorClass = "CONCURRENT_QUERY",
sqlState = Some("0A000"),
parameters = e.getMessageParameters.asScala.toMap
)
}
|
Looks like the test failure in CI is irrelevant. |
|
@MaxGekk Please either merge this or let me know once you're OK with the change. Thanks! |
MaxGekk
approved these changes
Oct 31, 2023
|
+1, LGTM. Merging to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The newly added test in 7d7afb0 could be flaky, this change deflakes it. Details see comments.
Why are the changes needed?
Deflaky
Does this PR introduce any user-facing change?
Test only change
How was this patch tested?
Test only change
Was this patch authored or co-authored using generative AI tooling?
No