Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-45690][CORE][SQL] Clean up deprecated type use of BufferedIterator/CanBuildFrom/Traversable #43569

Closed
wants to merge 1 commit into from

Conversation

LuciferYang
Copy link
Contributor

@LuciferYang LuciferYang commented Oct 28, 2023

What changes were proposed in this pull request?

This pr clean up type use of BufferedIterator/CanBuildFrom/Traversable due to they were marked as deprecated in Scala 2.13.0.

  @deprecated("Use scala.collection.BufferedIterator instead of scala.BufferedIterator", "2.13.0")
  type BufferedIterator[+A] = scala.collection.BufferedIterator[A]
  @deprecated("Use Iterable instead of Traversable", "2.13.0")
  type Traversable[+A] = scala.collection.Iterable[A]
  @deprecated("Use scala.collection.BuildFrom instead", "2.13.0")
  type CanBuildFrom[-From, -A, +C] = scala.collection.BuildFrom[From, A, C]

Why are the changes needed?

Clean up deprecated type usage.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Pass GitHub Actions

Was this patch authored or co-authored using generative AI tooling?

No

@@ -20,6 +20,7 @@ package org.apache.spark.util.collection
import java.io._
import java.util.Comparator

import scala.collection.BufferedIterator
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the used scala#BufferedIterator to scala.collection.BufferedIterator.

@@ -17,6 +17,8 @@

package org.apache.spark.sql.execution

import scala.collection.BufferedIterator
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant