[SPARK-45753][CORE] Support spark.deploy.driverIdPattern
#43615
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you review this Spark |
yaooqinn
reviewed
Nov 1, 2023
yaooqinn
reviewed
Nov 1, 2023
core/src/main/scala/org/apache/spark/internal/config/Deploy.scala
Outdated
Show resolved
Hide resolved
|
Patterns like below will use space for padding, "driver-%s-%4d".format("20231111111111", 1)
driver-20231111111111- 1Can we have a test too to see if other components, such as UI, driver work properly? |
|
Thank you for review.
|
dongjoon-hyun
commented
Nov 1, 2023
| ", e.g., `driver-20231031224459-0019`. Please be careful to generate unique IDs") | ||
| .version("4.0.0") | ||
| .stringConf | ||
| .checkValue(!_.format(new Date(), 0).exists(_.isWhitespace), "Whitespace is not allowed.") |
There was a problem hiding this comment.
We execute String.format here in advance to prevent the failure in Master class.
dongjoon-hyun
commented
Nov 1, 2023
| assert(master.invokePrivate(_newDriverId(submitDate)) === "my-driver-00001") | ||
| } | ||
|
|
||
| test("SPARK-45753: Prevent invalid driver id patterns") { |
There was a problem hiding this comment.
Here is a test case for that.
|
Could you review this once more, @yaooqinn ? I believe this is the best effort we can. |
yaooqinn
approved these changes
Nov 1, 2023
|
LGTM, thanks for the updates |
|
Thank you so much always! |
|
Thank you! Merged to master for Apache Spark 4.0.0. |
szehon-ho
pushed a commit
to szehon-ho/spark
that referenced
this pull request
Feb 7, 2024
### What changes were proposed in this pull request? This PR aims to support `spark.deploy.driverIdPattern` for Apache Spark 4.0.0. ### Why are the changes needed? This allows the users to be able to control driver ID pattern. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs with the newly added test case. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#43615 from dongjoon-hyun/SPARK-45753. Authored-by: Dongjoon Hyun <dhyun@apple.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to support
spark.deploy.driverIdPatternfor Apache Spark 4.0.0.Why are the changes needed?
This allows the users to be able to control driver ID pattern.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs with the newly added test case.
Was this patch authored or co-authored using generative AI tooling?
No.