[SPARK-45795][SQL] DS V2 supports push down Mode #43661
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beliefer
force-pushed
the
SPARK-45795
branch
2 times, most recently
from
4aff81f
to
d0d33ea
Compare
|
ping @huaxingao @cloud-fan |
HyukjinKwon
approved these changes
Nov 6, 2023
beliefer
force-pushed
the
SPARK-45795
branch
from
d0d33ea
to
cc8cad1
Compare
|
Merged to master. |
cloud-fan
reviewed
Dec 18, 2023
| @@ -41,6 +41,7 @@ | |||
| * <li><pre>REGR_R2(input1, input2)</pre> Since 3.4.0</li> | |||
| * <li><pre>REGR_SLOPE(input1, input2)</pre> Since 3.4.0</li> | |||
| * <li><pre>REGR_SXY(input1, input2)</pre> Since 3.4.0</li> | |||
| * <li><pre>MODE(input1[, inverse])</pre> Since 4.0.0</li> | |||
There was a problem hiding this comment.
This is very hacky. It's kind of we re-define the SQL semantic of the second parameter for MODE function only. Do we have existing examples?
There was a problem hiding this comment.
Got it. Let's improve it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR will translate the aggregate function
MODEfor pushdown.The constructor of aggregate function
MODEhas adeterministicparameter. When multiple values have the same greatest frequency then either any of values is returned ifdeterministicis false or is not defined, or the lowest value is returned ifdeterministicis true.If
deterministicis true, the semantics ofdeterministicis the same as the syntax supported by some databases (e.g. H2, Postgres) show below.The syntax is:
MODE() WITHIN GROUP (ORDER BY col).Note:
MODE() WITHIN GROUP (ORDER BY col)doesn't supportDISTINCTkeyword.Why are the changes needed?
DS V2 supports push down
ModeDoes this PR introduce any user-facing change?
'No'.
New feature.
How was this patch tested?
New test cases.
Was this patch authored or co-authored using generative AI tooling?
'No'.