Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-45828][SQL] Remove deprecated method in dsl #43708

Closed
wants to merge 1 commit into from

Conversation

panbingkun
Copy link
Contributor

@panbingkun panbingkun commented Nov 8, 2023

What changes were proposed in this pull request?

The pr aims to remove some deprecated method in dsl.

Why are the changes needed?

After #36646 (Apache Spark 3.4.0), the method def as(alias: Symbol): NamedExpression = Alias(expr, alias.name)() and def subquery(alias: Symbol): LogicalPlan = SubqueryAlias(alias.name, logicalPlan) has been marked as deprecated and we need to remove it in Spark 4.0.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass GA.

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added the SQL label Nov 8, 2023
@LuciferYang
Copy link
Contributor

cc @cloud-fan @ulysses-you FYI

Copy link
Contributor

@beliefer beliefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

allisonport-db pushed a commit to delta-io/delta that referenced this pull request Nov 21, 2023
…ethods

- [x] Spark
- [ ] Standalone
- [ ] Flink
- [ ] Kernel
- [ ] Other (fill in here)

This is companion change for apache/spark#43708. It replaces use of deprecated methods with `Symbol` parameter with methods with `String` parameter.

Existing unit test

No

Closes #2303

GitOrigin-RevId: a3cf851bcb1a8fb163d5748473b731b9e6857cbe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants