[SPARK-45752][SQL] Simplify the code for check unreferenced CTE relations #43727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beliefer
force-pushed
the
SPARK-45752_followup
branch
from
b39bdcd
to
ab994ec
Compare
amaliujia
reviewed
Nov 10, 2023
| if (refCount == 0) { | ||
| checkUnreferencedCTERelations(cteMap, visited, cteId) | ||
| } | ||
| if (refCount == 0) { |
There was a problem hiding this comment.
I think this misses some corners cases. For example
WITH
a as (select * from table_exists),
b as (select * from a),
c as (select * from table_non_exists),
d as (select * from c)
SELECT 1
So the code may only check a and b but lose the checking over c and d.
cc @cloud-fan
There was a problem hiding this comment.
I mean your current change may not be able to handle the proposed case.
There was a problem hiding this comment.
It seems the test case passed.
beliefer
force-pushed
the
SPARK-45752_followup
branch
from
ab994ec
to
8821a0d
Compare
beliefer
changed the title
cloud-fan
reviewed
Nov 10, 2023
| // If a CTE relation is never used, it will disappear after inline. Here we explicitly check | ||
| // analysis for it, to make sure the entire query plan is valid. | ||
| try { | ||
| // If a CTE relation ref count is 0, the other CTE relations that reference it | ||
| // should also be checked by checkAnalysis0. This code will also guarantee the leaf | ||
| // relations that do not reference any others are checked first. | ||
| val visited: mutable.Map[Long, Boolean] = mutable.Map.empty.withDefaultValue(false) | ||
| cteMap.foreach { case (cteId, _) => |
There was a problem hiding this comment.
Oh I didn't realize that we were doing a nested loop before, good catch!
cloud-fan
approved these changes
Nov 10, 2023
|
Merged to master |
|
late LGTM. Thank you @beliefer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
#43614 let unreferenced
CTEchecked byCheckAnalysis0.This PR follows up #43614 to simplify the code for check unreferenced CTE relations.
Why are the changes needed?
Simplify the code for check unreferenced CTE relations
Does this PR introduce any user-facing change?
'No'.
How was this patch tested?
Exists test cases.
Was this patch authored or co-authored using generative AI tooling?
'No'.