[SPARK-45882][SQL] BroadcastHashJoinExec propagate partitioning should respect CoalescedHashPartitioning #43753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulysses-you
force-pushed
the
partitioning
branch
from
7a7f465
to
155b86c
Compare
|
cc @dongjoon-hyun The AQE cache table fix has a perf regression. This PR fixes it |
cloud-fan
reviewed
Nov 13, 2023
|
|
||
| override def satisfies0(required: Distribution): Boolean = from.satisfies0(required) | ||
| override val expressions: Seq[Expression] = from.expressions |
There was a problem hiding this comment.
Suggested change
| override val expressions: Seq[Expression] = from.expressions | |
| override def expressions: Seq[Expression] = from.expressions |
cloud-fan
reviewed
Nov 13, 2023
| override protected def withNewChildrenInternal( | ||
| newChildren: IndexedSeq[Expression]): CoalescedHashPartitioning = | ||
| copy(from = from.copy(expressions = newChildren)) | ||
|
|
||
| override val numPartitions: Int = partitions.length | ||
|
|
||
| override def toString: String = from.toString | ||
| override def sql: String = from.sql |
There was a problem hiding this comment.
can we include CoalescedHashPartitioning in the string format?
There was a problem hiding this comment.
after second thought, we never hold the CoalescedHashPartitioning so just use the default behavior.
cloud-fan
reviewed
Nov 13, 2023
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/physical/partitioning.scala
Show resolved
Hide resolved
cloud-fan
approved these changes
Nov 13, 2023
|
thanks, merging to master! |
|
@ulysses-you can you also open backport PRs? thanks! |
ulysses-you
added a commit
to ulysses-you/spark
that referenced
this pull request
Nov 14, 2023
…d respect CoalescedHashPartitioning Add HashPartitioningLike trait and make HashPartitioning and CoalescedHashPartitioning extend it. When we propagate output partiitoning, we should handle HashPartitioningLike instead of HashPartitioning. This pr also changes the BroadcastHashJoinExec to use HashPartitioningLike to avoid regression. Avoid unnecessary shuffle exchange. yes, avoid regression add test no Closes apache#43753 from ulysses-you/partitioning. Authored-by: ulysses-you <ulyssesyou18@gmail.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
ulysses-you
added a commit
to ulysses-you/spark
that referenced
this pull request
Nov 14, 2023
…d respect CoalescedHashPartitioning Add HashPartitioningLike trait and make HashPartitioning and CoalescedHashPartitioning extend it. When we propagate output partiitoning, we should handle HashPartitioningLike instead of HashPartitioning. This pr also changes the BroadcastHashJoinExec to use HashPartitioningLike to avoid regression. Avoid unnecessary shuffle exchange. yes, avoid regression add test no Closes apache#43753 from ulysses-you/partitioning. Authored-by: ulysses-you <ulyssesyou18@gmail.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
ulysses-you
added a commit
that referenced
this pull request
Nov 14, 2023
…should respect CoalescedHashPartitioning This pr backport #43753 to branch-3.5 ### What changes were proposed in this pull request? Add HashPartitioningLike trait and make HashPartitioning and CoalescedHashPartitioning extend it. When we propagate output partiitoning, we should handle HashPartitioningLike instead of HashPartitioning. This pr also changes the BroadcastHashJoinExec to use HashPartitioningLike to avoid regression. ### Why are the changes needed? Avoid unnecessary shuffle exchange. ### Does this PR introduce _any_ user-facing change? yes, avoid regression ### How was this patch tested? add test ### Was this patch authored or co-authored using generative AI tooling? no Closes #43792 from ulysses-you/partitioning-3.5. Authored-by: ulysses-you <ulyssesyou18@gmail.com> Signed-off-by: youxiduo <youxiduo@corp.netease.com>
ulysses-you
added a commit
that referenced
this pull request
Nov 14, 2023
…should respect CoalescedHashPartitioning This pr backport #43753 to branch-3.4 ### What changes were proposed in this pull request? Add HashPartitioningLike trait and make HashPartitioning and CoalescedHashPartitioning extend it. When we propagate output partiitoning, we should handle HashPartitioningLike instead of HashPartitioning. This pr also changes the BroadcastHashJoinExec to use HashPartitioningLike to avoid regression. ### Why are the changes needed? Avoid unnecessary shuffle exchange. ### Does this PR introduce _any_ user-facing change? yes, avoid regression ### How was this patch tested? add test ### Was this patch authored or co-authored using generative AI tooling? no Closes #43793 from ulysses-you/partitioning-3.4. Authored-by: ulysses-you <ulyssesyou18@gmail.com> Signed-off-by: youxiduo <youxiduo@corp.netease.com>
szehon-ho
pushed a commit
to szehon-ho/spark
that referenced
this pull request
Feb 7, 2024
…should respect CoalescedHashPartitioning This pr backport apache#43753 to branch-3.4 ### What changes were proposed in this pull request? Add HashPartitioningLike trait and make HashPartitioning and CoalescedHashPartitioning extend it. When we propagate output partiitoning, we should handle HashPartitioningLike instead of HashPartitioning. This pr also changes the BroadcastHashJoinExec to use HashPartitioningLike to avoid regression. ### Why are the changes needed? Avoid unnecessary shuffle exchange. ### Does this PR introduce _any_ user-facing change? yes, avoid regression ### How was this patch tested? add test ### Was this patch authored or co-authored using generative AI tooling? no Closes apache#43793 from ulysses-you/partitioning-3.4. Authored-by: ulysses-you <ulyssesyou18@gmail.com> Signed-off-by: youxiduo <youxiduo@corp.netease.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add HashPartitioningLike trait and make HashPartitioning and CoalescedHashPartitioning extend it. When we propagate output partiitoning, we should handle HashPartitioningLike instead of HashPartitioning. This pr also changes the BroadcastHashJoinExec to use HashPartitioningLike to avoid regression.
Why are the changes needed?
Avoid unnecessary shuffle exchange.
Does this PR introduce any user-facing change?
yes, avoid regression
How was this patch tested?
add test
Was this patch authored or co-authored using generative AI tooling?
no