[SPARK-45912][SQL] Enhancement of XSDToSchema API: Change to HDFS API for cloud storage accessibility #43789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
changed the title
HyukjinKwon
reviewed
Nov 15, 2023
| } catch { | ||
| case _: Throwable => | ||
| // Handle case where it was added with sc.addFile | ||
| val addFileUrl = SparkFiles.get(xsdPath.toString) |
There was a problem hiding this comment.
When they are added by different scheme, e.g., hdfs://my_xsd_file, they are downloaded into local so SparkFiles.get(xsdPath.toString) should always the local file path. so you won't need to call hadoop FS.
HyukjinKwon
reviewed
Nov 15, 2023
| val fs = xsdPath.getFileSystem(SparkHadoopUtil.get.conf) | ||
| fs.open(xsdPath) | ||
| } catch { | ||
| case _: Throwable => |
There was a problem hiding this comment.
I think you should probably rethrow the exception if that's not found in SparkFiles?
There was a problem hiding this comment.
e.g.,
} catch {
case e: Throwable =>
logInfo(s"$xsdPath was not found, falling back to look up files added by Spark")
val f = new File(SparkFiles.get(xsdPath.toString))
if (f.exists()( {
new FileInputStream(f)
} else {
throw e
}Not tested :-).
|
Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Previously, it utilized
java.nio.path, which limited file reading to local file systems only. By changing this to an HDFS-compatible API, we now enable the XSDToSchema function to access files in cloud storage.Why are the changes needed?
We want to enable the XSDToSchema function to access files in cloud storage.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Unit tests
Was this patch authored or co-authored using generative AI tooling?
No