[SPARK-45827][SQL][FOLLOWUP] Fix variant parquet reader. #43825
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cloud-fan @HyukjinKwon could you help take a look? Thanks! |
cloud-fan
reviewed
Nov 16, 2023
| @@ -73,5 +73,12 @@ class VariantSuite extends QueryTest with SharedSparkSession { | |||
| values.map(v => if (v == null) "null" else v.debugString()).sorted | |||
| } | |||
| assert(prepareAnswer(input) == prepareAnswer(result)) | |||
|
|
|||
| withTempDir { dir => | |||
There was a problem hiding this comment.
The basic tests test case also test parquet write an read, why it didn't expose the bug?
There was a problem hiding this comment.
Because the variant values it writes are all non-null. This only causes an issue when there is a null variant value.
HyukjinKwon
changed the title
HyukjinKwon
changed the title
cloud-fan
approved these changes
Nov 16, 2023
|
thanks, merging to master! |
cloud-fan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a follow-up of #43707. The previous PR missed a piece in the variant parquet reader: we are treating the variant type as
struct<value binary, metadata binary>, so it also needs a similarassembleStructprocess in the Parquet reader to correctly set the nullness of variant values from def/rep levels.How was this patch tested?
Extend the existing unit test. It would fail without the change.