Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MLlib] Minor: UDF style update. #4388

Closed
wants to merge 3 commits into from
Closed

[MLlib] Minor: UDF style update. #4388

wants to merge 3 commits into from

Conversation

rxin
Copy link
Contributor

@rxin rxin commented Feb 5, 2015

No description provided.

mengxr
mengxr reviewed Feb 5, 2015
View reviewed changes
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
@@ -137,7 +137,9 @@ class LogisticRegressionModel private[ml] (
1.0 / (1.0 + math.exp(-margin))
} : Double)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

skipped this one

@SparkQA
Copy link

SparkQA commented Feb 5, 2015

Test build #26827 has started for PR 4388 at commit 5e068e3.

  • This patch merges cleanly.

@mengxr
Copy link
Contributor

mengxr commented Feb 5, 2015

LGTM.

@SparkQA
Copy link

SparkQA commented Feb 5, 2015

Test build #26829 has started for PR 4388 at commit 61d465b.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Feb 5, 2015

Test build #26827 has finished for PR 4388 at commit 5e068e3.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26827/
Test PASSed.

@SparkQA
Copy link

SparkQA commented Feb 5, 2015

Test build #26829 has finished for PR 4388 at commit 61d465b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26829/
Test PASSed.

asfgit pushed a commit that referenced this pull request Feb 5, 2015
@rxin
[MLlib] Minor: UDF style update.
4074674 
Author: Reynold Xin <rxin@databricks.com>

Closes #4388 from rxin/mllib-style and squashes the following commits:

61d465b [Reynold Xin] oops
3364295 [Reynold Xin] Missed one ..
5e068e3 [Reynold Xin] [MLlib] Minor: UDF style update.

(cherry picked from commit c3ba4d4)
Signed-off-by: Reynold Xin <rxin@databricks.com>
@asfgit asfgit closed this in c3ba4d4 Feb 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@rxin @SparkQA @mengxr @AmplabJenkins