Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-46007][TEST] Add AmmoniteTest test tag and mark ReplE2ESuite #43909

Closed
wants to merge 2 commits into from

Conversation

dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Nov 20, 2023

What changes were proposed in this pull request?

This PR aims to introduce AmmoniteTest test tag and mark ReplE2ESuite in order to allow disable Ammonite-related tests selectively.

Why are the changes needed?

There is a long-standing existing Ammonite issue.

Although we use a hack in GitHub Action, it's non-trivial to run the tests in various environment. For example, some systems doesn't has amm installation in the PATH.

shell: 'script -q -e -c "bash {0}"'
run: |
# Fix for TTY related issues when launching the Ammonite REPL in tests.
export TERM=vt100

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass the CIs.

I manually verified that the test suite is ignored successfully.

$ build/sbt assembly/package "connect-client-jvm/testOnly org.apache.spark.sql.application.ReplE2ESuite" -Phive -Pconnect -Dtest.exclude.tags=org.apache.spark.tags.AmmoniteTest
...
[info] ReplE2ESuite:
[info] Run completed in 433 milliseconds.
[info] Total number of tests run: 0
[info] Suites: completed 1, aborted 0
[info] Tests: succeeded 0, failed 0, canceled 0, ignored 0, pending 0
[info] No tests were executed.
[success] Total time: 17 s, completed Nov 20, 2023, 4:00:37 AM

Was this patch authored or co-authored using generative AI tooling?

No.

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-46007][TEST] Add AmmoniteTest and mark ReplE2ESuite [SPARK-46007][TEST] Add AmmoniteTest test tag and mark ReplE2ESuite Nov 20, 2023
@dongjoon-hyun
Copy link
Member Author

cc @HyukjinKwon and @LuciferYang

@dongjoon-hyun
Copy link
Member Author

Thank you, @LuciferYang !

@dongjoon-hyun
Copy link
Member Author

I'll wait for the full CI run~

@dongjoon-hyun
Copy link
Member Author

Merged to master for Apache Spark 4.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants