[SPARK-5618][Spark Core][Minor] Optimise utility code. #4396
Conversation
|
Can one of the admins verify this patch? |
| @@ -1067,9 +1067,9 @@ private[spark] object Utils extends Logging { | |||
| // finding the call site of a method. | |||
| val SPARK_CORE_CLASS_REGEX = | |||
| """^org\.apache\.spark(\.api\.java)?(\.util)?(\.rdd)?(\.broadcast)?\.[A-Z]""".r | |||
| val SCALA_CLASS_REGEX = """^scala""".r | |||
| val SCALA_CLASS = "scala" | |||
There was a problem hiding this comment.
LGTM but could this be called SCALA_CORE_CLASS_PREFIX? why is a lazy val needed? doesn't seem worth it.
There was a problem hiding this comment.
@srowen Thank you.
The reason for using a "lazy val" is as follows.
The function || takes two Boolean arguments, but only evaluates the second argument if the first is false:
scala> true || { println("!!"); false }
res0: Boolean = trueIf "isSparkCoreClass" is true, "className.startsWith (SCALA_CORE_CLASS_PREFIX)" does not need to be evaluated.
There was a problem hiding this comment.
Yes I understand that effect, but it's a trivial condition to check, so don't think it overcomes the overhead of the generated code to implement "lazy". It doesn't matter; it's merged.
There was a problem hiding this comment.
I got it, thank you!
|
Ok I'm merging this into master and 1.3 with Sean's comments. Thanks @fukuo33 |
No description provided.