[SPARK-46100][CORE][PYTHON] Reduce stack depth by replace (string|array).size with (string|array).length #44011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with (string|array).length
beliefer
force-pushed
the
SPARK-46100
branch
from
2e80105
to
fb4903f
Compare
beliefer
changed the title
|
Is this all the similar cases in the project? I think we can fix all cases in one PR :) |
It's very hard. I fix the cases in core module paid two hours. |
LuciferYang
approved these changes
Nov 25, 2023
srowen
approved these changes
Nov 25, 2023
|
Merged to master |
|
@srowen @LuciferYang Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
There are a lot of
[string|array].sizecalled.In fact, the size calls the underlying length, this behavior increase the stack length.
We should call
[string|array].lengthdirectly.We also get the compile waring
Replace .size with .length on arrays and stringsThis PR just improve the core module.
Why are the changes needed?
Reduce stack depth by replace (string|array).size with (string|array).length
Does this PR introduce any user-facing change?
'No'.
How was this patch tested?
Exists test cases.
Was this patch authored or co-authored using generative AI tooling?
'No'.