[SPARK-46151][PYTHON][DOCS] Hide the More drop-down button in the PySpark docs navigation bar
#44068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ySpark docs navigation bar
panbingkun
commented
Nov 29, 2023
| @@ -196,6 +196,7 @@ | |||
| # further. For a list of options available for each theme, see the | |||
| # documentation. | |||
| html_theme_options = { | |||
| "header_links_before_dropdown": 6, | |||
There was a problem hiding this comment.
default value is 5
There was a problem hiding this comment.
Oh, I was also thinking of fixing this.
|
Btw, seems like the code-block style is not applied properly in the PR title? 
Could you address it? |
panbingkun
changed the title
More" drop-down button in the PySpark docs navigation barMore drop-down button in the PySpark docs navigation bar
Done, is it OK now? |
|
I guess maybe you wanted to apply the style something like: Hide the "More" drop-down button in the PySpark docs navigation bar or Hide the But it's not a big deal, so the PR looks still good to me :-) |
HyukjinKwon
approved these changes
Nov 30, 2023
|
Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The pr aims to hide the
More drop-down buttonin the PySpark docs navigation bar.Why are the changes needed?
Because there is
only one itemunder theMore drop-down button, as following:Obviously, in our scenario, eliminating
More drop-down buttonand directly displayingMigration Guides menuin the navigation bar is more intuitive and convenient.After:
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manually test.
Was this patch authored or co-authored using generative AI tooling?
No.