[SPARK-46152][SQL] XML: Add DecimalType support in XML schema inference #44069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -39,6 +40,8 @@ class XmlInferSchema(options: XmlOptions, caseSensitive: Boolean) | |||
| extends Serializable | |||
| with Logging { | |||
|
|
|||
| private val decimalParser = ExprUtils.getDecimalParser(options.locale) | |||
There was a problem hiding this comment.
a qq - Does this parser function the same as our XSD conversion?
There was a problem hiding this comment.
If not, let's make a followup to match.
There was a problem hiding this comment.
This parser converts a decimal string to DecimalType. The one in XSDToSchema converts XSD type to DecimalType.
HyukjinKwon
approved these changes
Nov 30, 2023
|
Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add DecimalType support in XML schema inference
Why are the changes needed?
Add DecimalType support in XML schema inference
Does this PR introduce any user-facing change?
Yes, XML schema inference will infer DecimalType correctly.
How was this patch tested?
Added a new unit test
Was this patch authored or co-authored using generative AI tooling?
No