Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-46194][BUILD] Remove TODO comments left in SPARK-33775 #44103

Closed
wants to merge 2 commits into from

Conversation

LuciferYang
Copy link
Contributor

What changes were proposed in this pull request?

This pr just remove TODO SPARK-33805 because after #43890 merged, all TODOs related to cleaning up deprecated Scala APIs have been completed.

Why are the changes needed?

Remove completed TODO.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Pass GitHub Actions

Was this patch authored or co-authored using generative AI tooling?

No

@github-actions github-actions bot added the BUILD label Dec 1, 2023
@LuciferYang LuciferYang changed the title [SPARK-46194][BUILD] Clean up the TODO comments left in SPARK-33775 [SPARK-46194][BUILD] Remove TODO comments left in SPARK-33775 Dec 1, 2023
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

asl3 pushed a commit to asl3/spark that referenced this pull request Dec 5, 2023
### What changes were proposed in this pull request?
This pr just remove TODO SPARK-33805 because after apache#43890 merged, all TODOs related to cleaning up deprecated Scala APIs have been completed.

### Why are the changes needed?
Remove completed TODO.

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
Pass GitHub Actions

### Was this patch authored or co-authored using generative AI tooling?
No

Closes apache#44103 from LuciferYang/SPARK-46194.

Authored-by: yangjie01 <yangjie01@baidu.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants