[SPARK-46221][PS][DOCS] Change to_spark_io to spark.to_spark_io in quickstart_ps.ipynb
#44135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjornjorgensen
changed the title
to_spark_io to spark.to_spark_io in quickstart_ps.ipynbto_spark_io to spark.to_spark_io in quickstart_ps.ipynb
bjornjorgensen
changed the title
to_spark_io to spark.to_spark_io in quickstart_ps.ipynbto_spark_io to spark.to_spark_io in quickstart_ps.ipynb
|
@itholic will you have a look. |
| @@ -14457,7 +14457,7 @@ | |||
| } | |||
| ], | |||
| "source": [ | |||
| "psdf.to_spark_io('zoo.orc', format=\"orc\")\n", | |||
| "psdf.spark.to_spark_io('zoo.orc', format=\"orc\")\n", | |||
There was a problem hiding this comment.
Is this the only place to be updated for Apache Spark 4.0.0?
There was a problem hiding this comment.
Yes, it looks like this is the only one that was not changed in #43384
dongjoon-hyun
approved these changes
Dec 3, 2023
There was a problem hiding this comment.
+1, LGTM. Thank you for the confirmation, @bjornjorgensen .
HyukjinKwon
approved these changes
Dec 3, 2023
|
Merged to master. Since CI doesn't verify the change. |
|
Late LGTM. Thanks for fixing this. |
asl3
pushed a commit
to asl3/spark
that referenced
this pull request
Dec 5, 2023
…n `quickstart_ps.ipynb` ### What changes were proposed in this pull request? Change `to_spark_io` to `spark.to_spark_io` in `quickstart_ps.ipynb` ### Why are the changes needed? `to_spark_io` is change to `spark.to_spark_io` in spark 4.0 To have user guilds that works :) ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested?  ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#44135 from bjornjorgensen/spark.to_spark_io. Authored-by: Bjørn Jørgensen <bjornjorgensen@gmail.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
dbatomic
pushed a commit
to dbatomic/spark
that referenced
this pull request
Dec 11, 2023
…n `quickstart_ps.ipynb` ### What changes were proposed in this pull request? Change `to_spark_io` to `spark.to_spark_io` in `quickstart_ps.ipynb` ### Why are the changes needed? `to_spark_io` is change to `spark.to_spark_io` in spark 4.0 To have user guilds that works :) ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested?  ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#44135 from bjornjorgensen/spark.to_spark_io. Authored-by: Bjørn Jørgensen <bjornjorgensen@gmail.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Change
to_spark_iotospark.to_spark_ioinquickstart_ps.ipynbWhy are the changes needed?
to_spark_iois change tospark.to_spark_ioin spark 4.0To have user guilds that works :)
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?
No.