[SPARK-46230][PYTHON] Migrate RetriesExceeded into PySpark error
#44147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
reviewed
Dec 4, 2023
itholic
changed the title
RetriesExceeded and RetryException into PySpark error.RetriesExceeded into PySpark error.
HyukjinKwon
approved these changes
Dec 4, 2023
HyukjinKwon
changed the title
RetriesExceeded into PySpark error.RetriesExceeded into PySpark error
dongjoon-hyun
approved these changes
Dec 4, 2023
dongjoon-hyun
approved these changes
Dec 5, 2023
|
Thank you, @itholic and Hyukjin. Merged to master |
|
Thanks! |
dbatomic
pushed a commit
to dbatomic/spark
that referenced
this pull request
Dec 11, 2023
### What changes were proposed in this pull request? This PR proposes to migrate `RetriesExceeded` into PySpark error. ### Why are the changes needed? All errors defined from PySpark should be inherits `PySparkException` to keep the consistency of error messages generated from PySpark. ### Does this PR introduce _any_ user-facing change? No, it's internal refactoring for better error handling. ### How was this patch tested? The existing CI should pass. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#44147 from itholic/retires_exception. Authored-by: Haejoon Lee <haejoon.lee@databricks.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to migrate
RetriesExceededinto PySpark error.Why are the changes needed?
All errors defined from PySpark should be inherits
PySparkExceptionto keep the consistency of error messages generated from PySpark.Does this PR introduce any user-facing change?
No, it's internal refactoring for better error handling.
How was this patch tested?
The existing CI should pass.
Was this patch authored or co-authored using generative AI tooling?
No.