[SPARK-46236][PYTHON][DOCS] Using brighter color for docs h3 title for better visibility #44152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r better visibility
HyukjinKwon
approved these changes
Dec 4, 2023
|
Merged to master. |
asl3
pushed a commit
to asl3/spark
that referenced
this pull request
Dec 5, 2023
…r better visibility ### What changes were proposed in this pull request? The pr aims to using brighter color for docs `h3 title` for better visibility. ### Why are the changes needed? - Before: Dark theme: <img width="760" alt="image" src="https://github.com/apache/spark/assets/15246973/ee024e67-d86b-4960-968f-329b32d3e370"> Light theme: <img width="761" alt="image" src="https://github.com/apache/spark/assets/15246973/20a562ed-b9b5-44f6-bf52-30967fb7dc3a"> - After: Dark theme: <img width="780" alt="image" src="https://github.com/apache/spark/assets/15246973/546139b5-a94c-4dec-a4fb-24299b3388ba"> Light theme: <img width="769" alt="image" src="https://github.com/apache/spark/assets/15246973/4d912002-4c9e-46d0-a397-bcca0024f160"> ### Does this PR introduce _any_ user-facing change? No API changes, but the font color of the `h3 title` has been updated to a brighter color, improving contrast and readability. ### How was this patch tested? Manually test. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#44152 from panbingkun/SPARK-46236. Authored-by: panbingkun <pbk1982@gmail.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
dbatomic
pushed a commit
to dbatomic/spark
that referenced
this pull request
Dec 11, 2023
…r better visibility ### What changes were proposed in this pull request? The pr aims to using brighter color for docs `h3 title` for better visibility. ### Why are the changes needed? - Before: Dark theme: <img width="760" alt="image" src="https://github.com/apache/spark/assets/15246973/ee024e67-d86b-4960-968f-329b32d3e370"> Light theme: <img width="761" alt="image" src="https://github.com/apache/spark/assets/15246973/20a562ed-b9b5-44f6-bf52-30967fb7dc3a"> - After: Dark theme: <img width="780" alt="image" src="https://github.com/apache/spark/assets/15246973/546139b5-a94c-4dec-a4fb-24299b3388ba"> Light theme: <img width="769" alt="image" src="https://github.com/apache/spark/assets/15246973/4d912002-4c9e-46d0-a397-bcca0024f160"> ### Does this PR introduce _any_ user-facing change? No API changes, but the font color of the `h3 title` has been updated to a brighter color, improving contrast and readability. ### How was this patch tested? Manually test. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#44152 from panbingkun/SPARK-46236. Authored-by: panbingkun <pbk1982@gmail.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The pr aims to using brighter color for docs
h3 titlefor better visibility.Why are the changes needed?
Before:
Dark theme:
Light theme:
After:
Dark theme:
Light theme:
Does this PR introduce any user-facing change?
No API changes, but the font color of the
h3 titlehas been updated to a brighter color, improving contrast and readability.How was this patch tested?
Manually test.
Was this patch authored or co-authored using generative AI tooling?
No.