[SPARK-46186][CONNECT][TESTS][FOLLOWUP] Remove flakiness of ReattachableExecuteSuite
#44189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliuszsompolski
commented
Dec 5, 2023
Comment on lines
327
to
337
| // make sure the interrupt reaches the server | ||
| Eventually.eventually(timeout(eventuallyTimeout)) { | ||
| val execution = SparkConnectService.executionManager.listActiveExecutions match { | ||
| case Right(list) => list.find(_.operationId == operationId) | ||
| case Left(_) => None | ||
| } | ||
| assert(execution.isDefined && execution.get.status == ExecuteStatus.Canceled) | ||
| } | ||
| // make sure the client gets the OPERATION_CANCELED error | ||
| val e = intercept[StatusRuntimeException] { | ||
| while (iter.hasNext) iter.next() |
There was a problem hiding this comment.
While raising PR I realize this is not needed, because the sleep query should ensure that we don't get results to iterate through for 30 seconds. By this time, interrupt should reach the server.
Will remove and test for flakiness again.
dongjoon-hyun
changed the title
dongjoon-hyun
changed the title
ReattachableExecuteSuite
|
Thank you, @juliuszsompolski . |
|
Thank you, @juliuszsompolski . |
dbatomic
pushed a commit
to dbatomic/spark
that referenced
this pull request
Dec 11, 2023
…ableExecuteSuite` ### What changes were proposed in this pull request? The test added in apache#44095 could be flaky because `MEDIUM_RESULTS_QUERY` could very quickly finish before interrupt was sent. Replace it with a query that sleeps 30 seconds, so that we are sure that interrupt runs before it finishes. ### Why are the changes needed? Remove test flakiness. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Rerun ReattachableExecuteSuite 100+ times to check it isn't flaky. ### Was this patch authored or co-authored using generative AI tooling? Github Copilot was assisting in some boilerplate auto-completion. Generated-by: Github Copilot Closes apache#44189 from juliuszsompolski/SPARK-46186-followup. Authored-by: Juliusz Sompolski <julek@databricks.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The test added in #44095 could be flaky because
MEDIUM_RESULTS_QUERYcould very quickly finish before interrupt was sent. Replace it with a query that sleeps 30 seconds, so that we are sure that interrupt runs before it finishes.Why are the changes needed?
Remove test flakiness.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Rerun ReattachableExecuteSuite 100+ times to check it isn't flaky.
Was this patch authored or co-authored using generative AI tooling?
Github Copilot was assisting in some boilerplate auto-completion.
Generated-by: Github Copilot