[SPARK-46277][PYTHON] Validate startup urls with the config being set #44194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
changed the title
HyukjinKwon
approved these changes
Dec 6, 2023
xinrong-meng
force-pushed
the
fix_session
branch
from
5f6e721
to
9fefb05
Compare
|
Rebased changes from master and adjusted errors per 9fefb05. |
|
Also cc @itholic for error class changes |
itholic
approved these changes
Dec 7, 2023
dbatomic
pushed a commit
to dbatomic/spark
that referenced
this pull request
Dec 11, 2023
### What changes were proposed in this pull request?
Validate startup urls with the config being set, see example in the "Does this PR introduce _any_ user-facing change".
### Why are the changes needed?
Clear and user-friendly error messages.
### Does this PR introduce _any_ user-facing change?
Yes.
FROM
```py
>>> SparkSession.builder.config(map={"spark.master": "x", "spark.remote": "y"})
<pyspark.sql.session.SparkSession.Builder object at 0x7fa310115b20
>>> SparkSession.builder.config(map={"spark.master": "x", "spark.remote": "y"}).config("x", "z") # Only raises the error when adding new configs
Traceback (most recent call last):
...
RuntimeError: Spark master cannot be configured with Spark Connect server; however, found URL for Spark Connect [y]
```
TO
```py
>>> SparkSession.builder.config(map={"spark.master": "x", "spark.remote": "y"})
Traceback (most recent call last):
...
RuntimeError: Spark master cannot be configured with Spark Connect server; however, found URL for Spark Connect [y]
```
### How was this patch tested?
Unit tests.
### Was this patch authored or co-authored using generative AI tooling?
No.
Closes apache#44194 from xinrong-meng/fix_session.
Authored-by: Xinrong Meng <xinrong@apache.org>
Signed-off-by: Xinrong Meng <xinrong@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Validate startup urls with the config being set, see example in the "Does this PR introduce any user-facing change".
Why are the changes needed?
Clear and user-friendly error messages.
Does this PR introduce any user-facing change?
Yes.
FROM
TO
How was this patch tested?
Unit tests.
Was this patch authored or co-authored using generative AI tooling?
No.