[SPARK-46296][PYTHON][TESTS] Test missing test coverage for captured errors (pyspark.errors.exceptions) #44224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
commented
Dec 7, 2023
| @@ -104,7 +104,7 @@ def getMessageParameters(self) -> Optional[Dict[str, str]]: | |||
| if self._origin is not None and is_instance_of( | |||
| gw, self._origin, "org.apache.spark.SparkThrowable" | |||
| ): | |||
| return self._origin.getMessageParameters() | |||
| return dict(self._origin.getMessageParameters()) | |||
There was a problem hiding this comment.
this is virtually no-op. Before this change, it returns a JVM map instance that implements Python dictionary interface. After this change, it returns a pure Python dictionary.
HyukjinKwon
changed the title
HyukjinKwon
changed the title
|
Merged to master. |
dbatomic
pushed a commit
to dbatomic/spark
that referenced
this pull request
Dec 11, 2023
…errors (pyspark.errors.exceptions) ### What changes were proposed in this pull request? This PR adds tests for negative cases of `getErrorClass` and `getSqlState`. And test case for `getMessageParameters` for errors. ### Why are the changes needed? To improve the test coverage. See https://app.codecov.io/gh/apache/spark/commit/1a651753f4e760643d719add3b16acd311454c76/blob/python/pyspark/errors/exceptions/captured.py This is not being tested. ### Does this PR introduce _any_ user-facing change? No, test-only ### How was this patch tested? Manually ran the new unittest. ### Was this patch authored or co-authored using generative AI tooling? Np. Closes apache#44224 from HyukjinKwon/SPARK-46296. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds tests for negative cases of
getErrorClassandgetSqlState. And test case forgetMessageParametersfor errors.Why are the changes needed?
To improve the test coverage.
See https://app.codecov.io/gh/apache/spark/commit/1a651753f4e760643d719add3b16acd311454c76/blob/python/pyspark/errors/exceptions/captured.py This is not being tested.
Does this PR introduce any user-facing change?
No, test-only
How was this patch tested?
Manually ran the new unittest.
Was this patch authored or co-authored using generative AI tooling?
Np.