[SPARK-46261][CONNECT] DataFrame.withColumnsRenamed should keep the dict/map ordering
#44231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhengruifeng
changed the title
DataFrame.withColumnsRenamed should keep the dict/map orderingDataFrame.withColumnsRenamed should keep the dict/map ordering
zhengruifeng
force-pushed
the
connect_with_cols_rm
branch
from
b0882e6
to
3ea9be1
Compare
HyukjinKwon
approved these changes
Dec 7, 2023
dongjoon-hyun
approved these changes
Dec 7, 2023
|
Merged to master for Apache Spark 4. |
dbatomic
pushed a commit
to dbatomic/spark
that referenced
this pull request
Dec 11, 2023
… dict/map ordering ### What changes were proposed in this pull request? this is a follow up of apache#44177 ### Why are the changes needed? according to [this](https://protobuf.dev/programming-guides/proto3/#maps-features): > Wire format ordering and map iteration ordering of map values are undefined, so you cannot rely on your map items being in a particular order. we should not use `map` in protobufs when the ordering is sensitive ### Does this PR introduce _any_ user-facing change? yes, enabled test ### How was this patch tested? enabled UT ### Was this patch authored or co-authored using generative AI tooling? no Closes apache#44231 from zhengruifeng/connect_with_cols_rm. Authored-by: Ruifeng Zheng <ruifengz@apache.org> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
this is a follow up of #44177
Why are the changes needed?
according to this:
we should not use
mapin protobufs when the ordering is sensitiveDoes this PR introduce any user-facing change?
yes, enabled test
How was this patch tested?
enabled UT
Was this patch authored or co-authored using generative AI tooling?
no