[SPARK-46333][SQL] Replace IllegalStateException by SparkException.internalError in catalyst
#44263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGekk
changed the title
IllegalStateException by SparkException.internalError in catalystIllegalStateException by SparkException.internalError in catalyst
MaxGekk
changed the title
IllegalStateException by SparkException.internalError in catalystIllegalStateException by SparkException.internalError in catalyst
MaxGekk
changed the title
IllegalStateException by SparkException.internalError in catalystIllegalStateException by SparkException.internalError in catalyst
cloud-fan
approved these changes
Dec 8, 2023
LuciferYang
approved these changes
Dec 9, 2023
|
All tests passed: https://github.com/MaxGekk/spark/actions/runs/7149112248/job/19473080029 Merging to master. Thank you, @LuciferYang @cloud-fan for review. |
MaxGekk
changed the title
IllegalStateException by SparkException.internalError in catalystIllegalStateException by SparkException.internalError in catalyst
dbatomic
pushed a commit
to dbatomic/spark
that referenced
this pull request
Dec 11, 2023
….internalError` in catalyst ### What changes were proposed in this pull request? In the PR, I propose to replace all `IllegalStateException` exception in `catalyst` by `SparkException.internalError`. ### Why are the changes needed? This is a part of migration onto new error framework and error classes. ### Does this PR introduce _any_ user-facing change? No, users shouldn't face to `IllegalStateException` in regular cases. ### How was this patch tested? Using existing GAs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#44263 from MaxGekk/bind-ref-internal-error. Authored-by: Max Gekk <max.gekk@gmail.com> Signed-off-by: Max Gekk <max.gekk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the PR, I propose to replace all
IllegalStateExceptionexception incatalystbySparkException.internalError.Why are the changes needed?
This is a part of migration onto new error framework and error classes.
Does this PR introduce any user-facing change?
No, users shouldn't face to
IllegalStateExceptionin regular cases.How was this patch tested?
Using existing GAs.
Was this patch authored or co-authored using generative AI tooling?
No.