[SPARK-46337][SQL][CONNECT][PYTHON] Make CTESubstitution retain the PLAN_ID_TAG
#44268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud-fan
approved these changes
Dec 9, 2023
HyukjinKwon
approved these changes
Dec 9, 2023
|
Merged to master. |
dbatomic
pushed a commit
to dbatomic/spark
that referenced
this pull request
Dec 11, 2023
… `PLAN_ID_TAG`
### What changes were proposed in this pull request?
Make `CTESubstitution` retain the `PLAN_ID_TAG`
### Why are the changes needed?
before this PR:
```
df1 = spark.range(10)
df2 = spark.sql("with dt as (select 1 as ida) select ida as id from dt")
df1.join(df2, df1.id == df2.id)
AnalysisException: When resolving 'id, fail to find subplan with plan_id=2 in 'Join Inner, '`==`('id, 'id)
:- Range (0, 10, step=1, splits=Some(12))
+- WithCTE
:- CTERelationDef 4, false
: +- SubqueryAlias dt
: +- Project [1 AS ida#22]
: +- OneRowRelation
+- Project [ida#22 AS id#21]
+- SubqueryAlias dt
+- CTERelationRef 4, true, [ida#22], false
```
### Does this PR introduce _any_ user-facing change?
yes
### How was this patch tested?
added ut
### Was this patch authored or co-authored using generative AI tooling?
no
Closes apache#44268 from zhengruifeng/connect_plan_id_cte.
Authored-by: Ruifeng Zheng <ruifengz@apache.org>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Make
CTESubstitutionretain thePLAN_ID_TAGWhy are the changes needed?
before this PR:
Does this PR introduce any user-facing change?
yes
How was this patch tested?
added ut
Was this patch authored or co-authored using generative AI tooling?
no