[SPARK-46344][CORE] Warn properly when a driver exists successfully but master is disconnected #44278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ut master is disconnected
dongjoon-hyun
force-pushed
the
SPARK-46344
branch
from
dcb10f1
to
bd7374a
Compare
|
Could you review this PR, @viirya ? |
Hmm, I think the new warning log looks good. But does this change |
viirya
approved these changes
Dec 9, 2023
|
Yes, you're right. This is a |
|
Thank you, @viirya ! Since this is a log-only change, let me merge this~ Merged to master for Apache Spark 4.0.0. |
dbatomic
pushed a commit
to dbatomic/spark
that referenced
this pull request
Dec 11, 2023
…ut master is disconnected ### What changes were proposed in this pull request? This PR aims to warn properly when a driver exists successfully but master is disconnected. ### Why are the changes needed? In this case, `Master` considers them `Error` eventually.  **Worker Log** ``` 23/12/09 15:13:21 INFO Worker: Driver driver-20231209151301-0003 exited successfully === Master is disconnected here === 23/12/09 15:13:53 WARN Worker: Driver driver-20231209151332-0004 exited successfully while master is disconnected. === A new master starts and is connected here === 23/12/09 15:17:10 INFO Worker: Driver driver-20231209151707-0000 exited successfully ``` ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#44278 from dongjoon-hyun/SPARK-46344. Authored-by: Dongjoon Hyun <dhyun@apple.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
szehon-ho
pushed a commit
to szehon-ho/spark
that referenced
this pull request
Feb 7, 2024
…ut master is disconnected ### What changes were proposed in this pull request? This PR aims to warn properly when a driver exists successfully but master is disconnected. ### Why are the changes needed? In this case, `Master` considers them `Error` eventually.  **Worker Log** ``` 23/12/09 15:13:21 INFO Worker: Driver driver-20231209151301-0003 exited successfully === Master is disconnected here === 23/12/09 15:13:53 WARN Worker: Driver driver-20231209151332-0004 exited successfully while master is disconnected. === A new master starts and is connected here === 23/12/09 15:17:10 INFO Worker: Driver driver-20231209151707-0000 exited successfully ``` ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#44278 from dongjoon-hyun/SPARK-46344. Authored-by: Dongjoon Hyun <dhyun@apple.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to warn properly when a driver exists successfully but master is disconnected.
Why are the changes needed?
In this case,
Masterconsiders themErroreventually.Worker Log
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.