Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-46357] Replace incorrect documentation use of setConf with conf.set #44290

Closed
wants to merge 3 commits into from

Conversation

nchammas
Copy link
Contributor

What changes were proposed in this pull request?

setConf is a method on SQLContext. The docs perhaps used to refer to SQLContext, but now they refer to SparkSession, which does not have this method.

This PR updates the docs to use the appropriate method for making configuration settings against SparkSession.

Why are the changes needed?

The current documentation is incorrect.

Does this PR introduce any user-facing change?

Yes.

How was this patch tested?

No testing.

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added the DOCS label Dec 11, 2023
@nchammas
Copy link
Contributor Author

cc @gengliangwang for this minor documentation fix. (I just picked you since I see you recently worked on this file. Let me know if that's not appropriate.)

@yaooqinn yaooqinn closed this in 977f64f Dec 14, 2023
@yaooqinn
Copy link
Member

Thanks @nchammas, merged to master

@nchammas nchammas deleted the SPARK-46357-setConf-confset branch December 14, 2023 03:44
@nchammas
Copy link
Contributor Author

Thanks for reviewing, @yaooqinn. I didn't realize you were a committer! You may also be interested in reviewing #44300, which relates to #28274 which you previously worked on back in 2020.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants