[SPARK-42307][SQL][BUILD][DOCS] Adding in a better name for _LEGACY_ERROR_TEMP_2232
#44337
Conversation
hannahkamundson
force-pushed
the
SPARK-42307
branch
2 times, most recently
from
4ef59d2
to
3ff7198
Compare
hannahkamundson
changed the title
_LEGACY_ERROR_TEMP_2232_LEGACY_ERROR_TEMP_2232
|
@hannahkamundson Could you add a test for the error class, please. |
sql/api/src/test/scala/org/apache/spark/sql/errors/DataTypeErrorsSuite.scala
Outdated
Show resolved
Hide resolved
hannahkamundson
changed the title
_LEGACY_ERROR_TEMP_2232_LEGACY_ERROR_TEMP_2232
sql/api/src/test/scala/org/apache/spark/sql/catalyst/expressions/RowsSuite.scala
Outdated
Show resolved
Hide resolved
|
@MaxGekk Let me know what you think! |
|
@MaxGekk Any thoughts? |
|
|
||
| <dependency> | ||
| <groupId>org.apache.spark</groupId> | ||
| <artifactId>spark-core_${scala.binary.version}</artifactId> |
| import org.apache.spark.sql.catalyst.expressions.GenericRow | ||
|
|
||
| class RowSuite extends SparkFunSuite { | ||
| test("Row handles null value") { |
There was a problem hiding this comment.
Can you move it to some existing test suite?
There was a problem hiding this comment.
sql/api doesn't have any other tests. This was adding the first one.
Do you have a different package you want me to move it to?
Additionally, I think the dependency above is required in test because SparkFunSuite lives in core. I am not putting a dependency for the main code on core, just the test code. I'm fine changing that, but would need more guidance as to where I should put the test
hannahkamundson
force-pushed
the
SPARK-42307
branch
from
e0415dc
to
a5e2cd9
Compare
|
@MaxGekk Rebased on |
|
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
What changes were proposed in this pull request?
This adds a better name for the error type
_LEGACY_ERROR_TEMP_2232and updates the messages for it.Why are the changes needed?
All that was changed was the
_LEGACY_ERROR_TEMP_2232toNULL_ROW_VALUEsqlStatefor_LEGACY_ERROR_TEMP_2232_LEGACY_ERROR_TEMP_2232Does this PR introduce any user-facing change?
Yes.
sqlStatefor_LEGACY_ERROR_TEMP_2232to2200Ewhereas it was previously empty._LEGACY_ERROR_TEMP_2232fromValue at index <index> is null.toRow value at the position <index> is NULL.How was this patch tested?
Unit tests
Was this patch authored or co-authored using generative AI tooling?
No