[SPARK-46384][SPARK-46404][SS][UI] Fix Operation Duration Stack Chart on Structured Streaming Page #44346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaooqinn
commented
Dec 14, 2023
Comment on lines
-140
to
-144
| .on("mousemove", (event, d) => { | ||
| var xPosition = d3.pointer(event)[0] - 15; | ||
| var yPosition = d3.pointer(event)[1] - 25; | ||
| tooltip.attr("transform", "translate(" + xPosition + "," + yPosition + ")"); | ||
| tooltip.select("text").text(d.y); |
There was a problem hiding this comment.
Removed this because the color set doesn't define d.y.
yaooqinn
commented
Dec 14, 2023
| // pre-define some colors for legends. | ||
| var colorPool = ["#F8C471", "#F39C12", "#B9770E", "#73C6B6", "#16A085", "#117A65", "#B2BABB", "#7F8C8D", "#616A6B"]; | ||
|
|
||
| /* eslint-disable no-unused-vars */ | ||
| function drawAreaStack(id, labels, values, minX, maxX, minY, maxY) { |
There was a problem hiding this comment.
minX, maxX, minY, maxY removed as we never touch them
yaooqinn
commented
Dec 14, 2023
| @@ -145,6 +143,8 @@ private[spark] class JsCollector { | |||
| */ | |||
| private val statements = ArrayBuffer[String]() | |||
|
|
|||
| private val imports = mutable.Set[String]() | |||
There was a problem hiding this comment.
make it a set to avoid duplicated imports
yaooqinn
changed the title
yaooqinn
changed the title
cloud-fan
approved these changes
Dec 14, 2023
LuciferYang
approved these changes
Dec 14, 2023
core/src/main/resources/org/apache/spark/ui/static/structured-streaming-page.js
Show resolved
Hide resolved
sarutak
approved these changes
Dec 14, 2023
|
Thanks all. Merged to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In this PR, we feed correct data to d3.stack() according to the API Change. https://d3js.org/d3-shape/stack
Why are the changes needed?
Fix Operation Duration Stack Chart
Does this PR introduce any user-facing change?
no
How was this patch tested?
UI UT tests Add
ui-test/tests/structured-streaming-page.test.js
Local tests
Was this patch authored or co-authored using generative AI tooling?
no