[SPARK-46453][CONNECT] Throw exception from internalError() in SessionHolder
#44400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGekk
changed the title
internalError() in SessionHolderinternalError() in SessionHolder
dongjoon-hyun
requested changes
Dec 18, 2023
There was a problem hiding this comment.
Please file a new JIRA issue for this bug fix, @MaxGekk .
This is a valid bug fix and cannot be a follow-up because SPARK-43474 is released as a part of Apache Spark 3.5.0.
HyukjinKwon
approved these changes
Dec 19, 2023
MaxGekk
changed the title
internalError() in SessionHolderinternalError() in SessionHolder
|
@dongjoon-hyun Created new JIRA and replaced old one in PR's title. |
|
Merging to master/3.5. Thank you, @dongjoon-hyun and @HyukjinKwon for review. |
MaxGekk
added a commit
that referenced
this pull request
Dec 19, 2023
…sionHolder` ### What changes were proposed in this pull request? In the PR, I propose to throw `SparkException` returned by `internalError` in `SessionHolder`. ### Why are the changes needed? Without the bug fix user won't see the internal error. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? N/a ### Was this patch authored or co-authored using generative AI tooling? No. Closes #44400 from MaxGekk/throw-internal-error. Authored-by: Max Gekk <max.gekk@gmail.com> Signed-off-by: Max Gekk <max.gekk@gmail.com> (cherry picked from commit dc0bfc4) Signed-off-by: Max Gekk <max.gekk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the PR, I propose to throw
SparkExceptionreturned byinternalErrorinSessionHolder.Why are the changes needed?
Without the bug fix user won't see the internal error.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
N/a
Was this patch authored or co-authored using generative AI tooling?
No.