[SPARK-46478][SQL] Revert SPARK-43049 to use oracle varchar(255) for string #44442
+24
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
approved these changes
Dec 22, 2023
|
I will close my PR #44452. FYI: This one appears to be a logical revert, not the actual commit revert. |
|
@HyukjinKwon I think it would be good to combine my PR description with this one to give a bit more context. |
cloud-fan
reviewed
Dec 22, 2023
| @@ -88,6 +89,11 @@ class OracleIntegrationSuite extends DockerJDBCIntegrationV2Suite with V2JDBCTes | |||
| s"jdbc:oracle:thin:system/$oracle_password@//$ip:$port/freepdb1" | |||
| } | |||
|
|
|||
| override val defaultMetadata = new MetadataBuilder() | |||
There was a problem hiding this comment.
The superclass tests with strings. As we use varchar to map string values for Oracle, it's now a special case.
cloud-fan
approved these changes
Dec 22, 2023
|
Merged to master. Could you make a backport PR for branch-3.5, @yaooqinn ? |
|
Thank you, @dongjoon-hyun. I'm OOO now. I will raise a backport PR tomorrow. |
yaooqinn
added a commit
to yaooqinn/spark
that referenced
this pull request
Dec 26, 2023
…string ### What changes were proposed in this pull request? Revert SPARK-43049 to use Oracle Varchar (255) for string for performance consideration ### Why are the changes needed? for performance consideration ### Does this PR introduce _any_ user-facing change? yes, storing strings in Oracle table, which is defined by spark DDL with string columns. Users will get an error if string values exceed 255 ```java org.apache.spark.SparkRuntimeException: [EXCEED_LIMIT_LENGTH] Exceeds char/varchar type length limitation: 255. SQLSTATE: 54006 [info] at org.apache.spark.sql.errors.QueryExecutionErrors$.exceedMaxLimit(QueryExecutionErrors.scala:2512) ``` ### How was this patch tested? revised unit tests ### Was this patch authored or co-authored using generative AI tooling? no Closes apache#44452 Closes apache#44442 from yaooqinn/SPARK-46478. Authored-by: Kent Yao <yao@apache.org> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Revert SPARK-43049 to use Oracle Varchar (255) for string for performance consideration
Why are the changes needed?
for performance consideration
Does this PR introduce any user-facing change?
yes, storing strings in Oracle table, which is defined by spark DDL with string columns. Users will get an error if string values exceed 255
How was this patch tested?
revised unit tests
Was this patch authored or co-authored using generative AI tooling?
no
Closes #44452