Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-46484][SQL][CONNECT] Retain plan_id in resolveOperators #44455

Closed

Conversation

zhengruifeng
Copy link
Contributor

What changes were proposed in this pull request?

Retain plan_id in resolveOperators

Why are the changes needed?

another attempt to fix #44454

Does this PR introduce any user-facing change?

no

How was this patch tested?

added ut

Was this patch authored or co-authored using generative AI tooling?

no

@zhengruifeng
Copy link
Contributor Author

zhengruifeng commented Dec 22, 2023

this is the previous approach to fix missing plan_id issue:
1, figure out what rules drop the plan_id tag;
2, use copyTagsFrom to copy the tag from old plan to new plan;

Both UnpivotCoercion and ResolveUnpivot leverage resolveOperatorsDownWithPruning, so I'm trying to fix it by making resolveOperatorsDownWithPruning keep the plan_id tag;

cc @cloud-fan @HyukjinKwon

@zhengruifeng
Copy link
Contributor Author

close in favor of #44462

@zhengruifeng zhengruifeng deleted the resolve_helper_plan_id branch December 29, 2023 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant