Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-5664][BUILD] Restore stty settings when exiting from SBT's spark-shell #4451

Closed
wants to merge 1 commit into from
Closed

[SPARK-5664][BUILD] Restore stty settings when exiting from SBT's spark-shell #4451

wants to merge 1 commit into from

Conversation

viirya
Copy link
Member

@viirya viirya commented Feb 7, 2015

For launching spark-shell from SBT.

@SparkQA
Copy link

SparkQA commented Feb 7, 2015

Test build #27000 has finished for PR 4451 at commit fdfc480.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@viirya
Copy link
Member Author

viirya commented Feb 7, 2015

Looks like an unrelated failure? Please test it again.

@viirya viirya changed the title [SPARK-5664][BUILD] Restore stty settings when exiting [SPARK-5664][BUILD] Restore stty settings when exiting from SBT's spark-shell Feb 7, 2015
@viirya
Copy link
Member Author

viirya commented Feb 8, 2015

CC @marmbrus.

@marmbrus
Copy link
Contributor

marmbrus commented Feb 9, 2015

test this please

@SparkQA
Copy link

SparkQA commented Feb 9, 2015

Test build #27062 has finished for PR 4451 at commit fdfc480.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@pwendell
Copy link
Contributor

pwendell commented Feb 9, 2015

Sure, LGTM

asfgit pushed a commit that referenced this pull request Feb 9, 2015
@viirya @marmbrus
[SPARK-5664][BUILD] Restore stty settings when exiting from SBT's spa…
fa67877 
…rk-shell

For launching spark-shell from SBT.

Author: Liang-Chi Hsieh <viirya@gmail.com>

Closes #4451 from viirya/restore_stty and squashes the following commits:

fdfc480 [Liang-Chi Hsieh] Restore stty settings when exit (for launching spark-shell from SBT).

(cherry picked from commit dae2161)
Signed-off-by: Michael Armbrust <michael@databricks.com>
@marmbrus
Copy link
Contributor

marmbrus commented Feb 9, 2015

Thanks! Merged to master and branch-1.3

@asfgit asfgit closed this in dae2161 Feb 9, 2015
@viirya viirya deleted the restore_stty branch December 27, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@viirya @SparkQA @marmbrus @pwendell