[SPARK-37039][PS] Fix Series.astype to work properly with missing value
#44570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
approved these changes
Jan 3, 2024
HyukjinKwon
reviewed
Jan 3, 2024
| @@ -54,10 +54,7 @@ def test_astype(self): | |||
| lambda: psser.astype(int_type), | |||
| ) | |||
|
|
|||
| # TODO(SPARK-37039): the np.nan series.astype(bool) should be True | |||
There was a problem hiding this comment.
Should probably add this into migration guide though.
dongjoon-hyun
previously approved these changes
Jan 3, 2024
|
Oh, it seems the the failures are relevant, @itholic . |
|
@itholic can you retrigger and/or fix the tests? |
|
Oh.. seems like we should separately handle the boolean data type. I got some personal errands right now, so let me take a look tomorrow. Thanks! |
itholic
changed the title
Series.astype to work properly with missing valueSeries.astype to work properly with missing value
|
CI passed. @dongjoon-hyun @HyukjinKwon FYI |
itholic
changed the title
Series.astype to work properly with missing valueSeries.astype to work properly with missing value
|
Merged to master. |
yaooqinn
pushed a commit
that referenced
this pull request
Jan 11, 2024
### What changes were proposed in this pull request? This PR followup for #44570 to add migration guide for behavior change. ### Why are the changes needed? We should notice user about any behavior change ### Does this PR introduce _any_ user-facing change? No API change. ### How was this patch tested? The existing CI should pass. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #44684 from itholic/SPARK-37039-foolowup. Authored-by: Haejoon Lee <haejoon.lee@databricks.com> Signed-off-by: Kent Yao <yao@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to fix
Series.astypeto work properly with missing value.Why are the changes needed?
To follow the behavior of latest Pandas.
Does this PR introduce any user-facing change?
Yes, the bug is fixed to follow the behavior of Pandas:
Before
After
How was this patch tested?
Enable the existing UTs.
Was this patch authored or co-authored using generative AI tooling?
No.