[SPARK-46586][SQL] Support s.c.immutable.ArraySeq as customCollectionCls in MapObjects
#44591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ionCls` in `MapObjects`
LuciferYang
reviewed
Jan 4, 2024
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
Outdated
Show resolved
Hide resolved
LuciferYang
reviewed
Jan 4, 2024
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
Outdated
Show resolved
Hide resolved
LuciferYang
reviewed
Jan 4, 2024
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
Outdated
Show resolved
Hide resolved
Co-authored-by: YangJie <yangjie01@baidu.com>
…Cls in MapObjects
LuciferYang
reviewed
Jan 4, 2024
...talyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ObjectExpressionsSuite.scala
Show resolved
Hide resolved
…Cls in MapObjects
|
GA have passed, could you please update the PR description? @panbingkun |
Done. |
|
cc @cloud-fan @viirya @MaxGekk @dongjoon-hyun FYI |
cloud-fan
reviewed
Jan 5, 2024
| @@ -938,6 +939,14 @@ case class MapObjects private( | |||
| executeFuncOnCollection(input).foreach(builder += _) | |||
| mutable.ArraySeq.make(builder.result()) | |||
| } | |||
| case Some(cls) if classOf[immutable.ArraySeq[_]].isAssignableFrom(cls) => | |||
There was a problem hiding this comment.
not related to this PR, but this MapObjects expression gets more and more complicated. Can we rewrite it with RuntimeReplacable using StaticInvoke/Invoke so that we can implement it with pure scala?
There was a problem hiding this comment.
Okay, let me give it a try.
cloud-fan
approved these changes
Jan 5, 2024
|
Merged to master. Thank you, @panbingkun and @cloud-fan . |
cloud-fan
reviewed
Jan 5, 2024
| Row(ArrayBuffer(100))) | ||
|
|
||
| val myUdf2 = udf((a: immutable.ArraySeq[Int]) => | ||
| immutable.ArraySeq.unsafeWrapArray[Int](a.appended(5).appended(6).toArray)) |
There was a problem hiding this comment.
super nit: isn't it more common to use :+ to create new immutable collection with new elements?
There was a problem hiding this comment.
Okay, let me improve it.
vinodkc
pushed a commit
to vinodkc/spark
that referenced
this pull request
Jan 5, 2024
…ionCls` in `MapObjects` ### What changes were proposed in this pull request? The pr aims to support `s.c.immutable.ArraySeq` as `customCollectionCls` in `MapObjects`. ### Why are the changes needed? Because `s.c.immutable.ArraySeq` is a commonly used type in Scala 2.13, we should support it. ### Does this PR introduce _any_ user-facing change? Yes, We support `s.c.immutable.ArraySeq` in `MapObjects`. ### How was this patch tested? - Add new UT: Added a new test for `ArraySeq` in UDFSuite; Also updated `ObjectExpressionsSuite` for `MapObjects`. - Pass GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#44591 from panbingkun/SPARK-46586. Lead-authored-by: panbingkun <panbingkun@baidu.com> Co-authored-by: panbingkun <pbk1982@gmail.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
This was referenced Jan 8, 2024
LuciferYang
pushed a commit
that referenced
this pull request
Jan 12, 2024
### What changes were proposed in this pull request? The pr is following up #44591. ### Why are the changes needed? Fix issues in comments. <img width="908" alt="image" src="https://github.com/apache/spark/assets/15246973/deec66a1-1bd1-44bc-9c16-f1fe8bbb14e8"> ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? - Pass GA. - Manually test. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #44702 from panbingkun/SPARK-46586_fix. Authored-by: panbingkun <panbingkun@baidu.com> Signed-off-by: yangjie01 <yangjie01@baidu.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The pr aims to support
s.c.immutable.ArraySeqascustomCollectionClsinMapObjects.Why are the changes needed?
Because
s.c.immutable.ArraySeqis a commonly used type in Scala 2.13, we should support it.Does this PR introduce any user-facing change?
Yes, We support
s.c.immutable.ArraySeqinMapObjects.How was this patch tested?
ArraySeqin UDFSuite; Also updatedObjectExpressionsSuiteforMapObjects.Was this patch authored or co-authored using generative AI tooling?
No.