-
Notifications
You must be signed in to change notification settings - Fork 28.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-46683] Write a subquery generator that generates subqueries permutations to increase testing coverage #44599
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit bef8011.
…ossDbmsQueryTestSuite
@cloud-fan @jchen5 Open for reviews! I listed some potential issues in the PR description:
|
@cloud-fan @jchen5 Changed it to not produce golden files instead, just a normal test suite. |
cloud-fan
reviewed
Jan 22, 2024
sql/core/src/test/scala/org/apache/spark/sql/QueryGeneratorHelper.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Jan 22, 2024
sql/core/src/test/scala/org/apache/spark/sql/QueryGeneratorHelper.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Jan 22, 2024
sql/core/src/test/scala/org/apache/spark/sql/QueryGeneratorHelper.scala
Outdated
Show resolved
Hide resolved
cloud-fan
approved these changes
Jan 22, 2024
be2bc9a
to
c3013c7
Compare
@cloud-fan Can we merge? Thanks! |
thanks, merging to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR creates a suite,
GeneratedSubquerySuite
, that generates SQL with variations of subqueries. These variations include:How this works is that this suite generates SQL queries, and are then run against Postgres using docker integration tests.
Why are the changes needed?
There are a lot of subquery correctness issues, ranging from very old bugs to new ones that are being introduced due to work being done on subquery correlation optimization. This is especially in the areas of COUNT bugs and null behaviors.
To increase test coverage and robustness in this area, we want to write a subquery generator that writes variations of subqueries, producing SQL tests.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
This PR adds test. NA.
Was this patch authored or co-authored using generative AI tooling?
No.