[SPARK-46607][PYTHON][TESTS] Check the testing mode #44611
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhengruifeng
force-pushed
the
py_testing_mode
branch
from
7a1df12
to
28ca22b
Compare
zhengruifeng
force-pushed
the
py_testing_mode
branch
from
28ca22b
to
7320739
Compare
zhengruifeng
commented
Jan 5, 2024
| @@ -19,10 +19,14 @@ | |||
|
|
|||
| from pyspark.pandas.tests.groupby.test_grouping import GroupingTestsMixin | |||
| from pyspark.testing.connectutils import ReusedConnectTestCase | |||
| from pyspark.testing.pandasutils import PandasOnSparkTestCase | |||
| from pyspark.testing.pandasutils import PandasOnSparkTestUtils | |||
There was a problem hiding this comment.
manually check that, before this fix this test suite fails with
test_getitem (pyspark.pandas.tests.connect.groupby.test_parity_grouping.GroupingParityTests.test_getitem) ... ok (0.022s)
test_assert_vanilla_mode (pyspark.testing.pandasutils.PandasOnSparkTestCase.test_assert_vanilla_mode) ... ok (0.000s)
test_assert_remote_mode (pyspark.testing.connectutils.ReusedConnectTestCase.test_assert_remote_mode) ... ok (0.000s)
======================================================================
FAIL [0.003s]: test_assert_remote_mode (pyspark.pandas.tests.connect.groupby.test_parity_grouping.GroupingParityTests.test_assert_remote_mode)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/Users/ruifeng.zheng/Dev/spark/python/pyspark/testing/connectutils.py", line 199, in test_assert_remote_mode
self.assertTrue(is_remote())
AssertionError: False is not true
----------------------------------------------------------------------
Ran 6 tests in 8.455s
|
cc @HyukjinKwon and @itholic please take a look |
itholic
approved these changes
Jan 6, 2024
| def test_assert_remote_mode(self): | ||
| from pyspark.sql import is_remote | ||
|
|
||
| self.assertTrue(is_remote()) |
HyukjinKwon
approved these changes
Jan 7, 2024
|
Merged to master. |
|
thanks @HyukjinKwon and @itholic for reivews |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
1, check the testing mode:
test_assert_vanilla_modeinReusedPySparkTestCasetest_assert_remote_modeinReusedConnectTestCaseuse different function names in case a test suite inherit them both
2, fix the incorrect testing mode introduced in #44196
Why are the changes needed?
incorrect usage of
PandasOnSparkTestCase(subclass ofReusedPySparkTestCase) in parity tests cause test with vanilla Spark Session:#44196
#44592
Does this PR introduce any user-facing change?
no
How was this patch tested?
ci, added UT
Was this patch authored or co-authored using generative AI tooling?
no