[SPARK-46618][SQL] Improve error messages for DATA_SOURCE_NOT_FOUND error #44620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGekk
requested changes
Jan 8, 2024
| @@ -2233,7 +2233,7 @@ abstract class DDLSuite extends QueryTest with DDLSuiteBase { | |||
| val table2 = catalog.getTableMetadata(TableIdentifier("t2")) | |||
| assert(table2.provider == Some("hive")) | |||
|
|
|||
| val e1 = intercept[SparkClassNotFoundException] { | |||
There was a problem hiding this comment.
Could you remove unused import:
import org.apache.spark.{SparkClassNotFoundException ...
[ERROR] /Users/maximgekk/proj/review-allisonwang-db_spark-46618-not-found-err/sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala:27: Unused import
Applicable -Wconf / @nowarn filters for this fatal warning: msg=<part of the message>, cat=unused-imports, site=org.apache.spark.sql.execution.command
allisonwang-db
force-pushed
the
spark-46618-not-found-err
branch
from
cefa48f
to
f44246d
Compare
|
cc @MaxGekk |
MaxGekk
approved these changes
Jan 17, 2024
|
The test failures are not related to the PR, I do believe. +1, LGTM. Merging to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR improves the error messages for the
DATA_SOURCE_NOT_FOUNDerror.Why are the changes needed?
To make the error messages more user-friendly and update to date.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing unit tests.
Was this patch authored or co-authored using generative AI tooling?
No