Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-46628][INFRA] Use SPDX short identifier in license name #44631

Closed
wants to merge 1 commit into from

Conversation

dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Jan 8, 2024

What changes were proposed in this pull request?

This PR aims to use SPDX short identifier as license's name field.

Why are the changes needed?

SPDX short identifier is recommended as name field by Apache Maven.

ASF pom file has been using it. This PR aims to match with ASF pom file.

<name>Apache-2.0</name>

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Manual review.

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added the BUILD label Jan 8, 2024
@dongjoon-hyun
Copy link
Member Author

Thank you, @HyukjinKwon !

dongjoon-hyun added a commit that referenced this pull request Jan 9, 2024
### What changes were proposed in this pull request?

This PR aims to use SPDX short identifier as `license`'s `name` field.

- https://spdx.org/licenses/Apache-2.0.html

### Why are the changes needed?

SPDX short identifier is recommended as `name` field by `Apache Maven`.
- https://maven.apache.org/pom.html#Licenses

ASF pom file has been using it. This PR aims to match with ASF pom file.
- apache/maven-apache-parent#118
- https://github.com/apache/maven-apache-parent/blob/7888bdb8ee653ecc03b5fee136540a607193c240/pom.xml#L46
```
<name>Apache-2.0</name>
```

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Manual review.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #44631 from dongjoon-hyun/SPARK-46628.

Authored-by: Dongjoon Hyun <dhyun@apple.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
(cherry picked from commit d008f81)
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
dongjoon-hyun added a commit that referenced this pull request Jan 9, 2024
### What changes were proposed in this pull request?

This PR aims to use SPDX short identifier as `license`'s `name` field.

- https://spdx.org/licenses/Apache-2.0.html

### Why are the changes needed?

SPDX short identifier is recommended as `name` field by `Apache Maven`.
- https://maven.apache.org/pom.html#Licenses

ASF pom file has been using it. This PR aims to match with ASF pom file.
- apache/maven-apache-parent#118
- https://github.com/apache/maven-apache-parent/blob/7888bdb8ee653ecc03b5fee136540a607193c240/pom.xml#L46
```
<name>Apache-2.0</name>
```

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Manual review.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #44631 from dongjoon-hyun/SPARK-46628.

Authored-by: Dongjoon Hyun <dhyun@apple.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
(cherry picked from commit d008f81)
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
@dongjoon-hyun
Copy link
Member Author

Merged to master/3.5/3.4.

@dongjoon-hyun dongjoon-hyun deleted the SPARK-46628 branch January 9, 2024 00:24
szehon-ho pushed a commit to szehon-ho/spark that referenced this pull request Feb 7, 2024
### What changes were proposed in this pull request?

This PR aims to use SPDX short identifier as `license`'s `name` field.

- https://spdx.org/licenses/Apache-2.0.html

### Why are the changes needed?

SPDX short identifier is recommended as `name` field by `Apache Maven`.
- https://maven.apache.org/pom.html#Licenses

ASF pom file has been using it. This PR aims to match with ASF pom file.
- apache/maven-apache-parent#118
- https://github.com/apache/maven-apache-parent/blob/7888bdb8ee653ecc03b5fee136540a607193c240/pom.xml#L46
```
<name>Apache-2.0</name>
```

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Manual review.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes apache#44631 from dongjoon-hyun/SPARK-46628.

Authored-by: Dongjoon Hyun <dhyun@apple.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
(cherry picked from commit d008f81)
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants