[SPARK-46630][SQL] XML: Validate XML element name on write #44634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/xml/XmlSuite.scala
Show resolved
Hide resolved
shujingyang-db
approved these changes
Jan 9, 2024
HyukjinKwon
approved these changes
Jan 9, 2024
|
Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Validate XML element name on write. Spark SQL permits spaces in field names and they may even start with number or special characters. These field names cannot be converted to XML element names. This PR adds validation to throw error on non-compliant XML element names.
This applies only to XML write. Validation is on by default. User can choose to disable this validation.
Why are the changes needed?
Same as above
Does this PR introduce any user-facing change?
Yes
How was this patch tested?
New unit test
Was this patch authored or co-authored using generative AI tooling?
No