[SPARK-46660][CONNECT] ReattachExecute requests updates aliveness of SessionHolder #44670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You mean ReleaseExecute handler? |
juliuszsompolski
approved these changes
Jan 11, 2024
...ector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SessionHolder.scala
Outdated
Show resolved
Hide resolved
...src/main/scala/org/apache/spark/sql/connect/service/SparkConnectReattachExecuteHandler.scala
Outdated
Show resolved
Hide resolved
...src/main/scala/org/apache/spark/sql/connect/service/SparkConnectReattachExecuteHandler.scala
Show resolved
Hide resolved
grundprinzip
approved these changes
Jan 12, 2024
HyukjinKwon
approved these changes
Jan 15, 2024
|
Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR makes
SparkConnectReattachExecuteHandlerfetch theExecuteHoldervia theSessionHolderwhich in turn refreshes it's aliveness. Further, this makes it consistent withSparkConnectReleaseExecuteHandler.Why are the changes needed?
Currently in ReattachExecute, we fetch the ExecuteHolder directly without going through the SessionHolder and hence the "aliveness" of the SessionHolder is not refreshed.
This would result in long-running queries (which do not send
ReleaseExecuterequests in specific) failing because theSessionHolderwould expire from the cache during an active query execution.Does this PR introduce any user-facing change?
Yes, it fixes the bug where long-running may fail when their corresponding
SessionHolderis expired during active query execution.How was this patch tested?
New unit test.
Was this patch authored or co-authored using generative AI tooling?
No.