-
Notifications
You must be signed in to change notification settings - Fork 28.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-46733][CORE] Simplify the BlockManager by the exit operation only depend on interrupt thread. #44732
Conversation
b08cc58
to
1ae6dc4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unlike ReloadingX509TrustManager
, here the InterruptedException
is caught and ignored in some of the downstream methods: so we cant rely on that pattern here.
…ation only depend on interrupt thread.
1ae6dc4
to
5c42f29
Compare
I reverted the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me.
+CC @dongjoon-hyun as well who reviewed the prev pr.
This change of this pr is fine to me. However, I would like to raise a question: Would it be simpler and clearer to implement the logic for cleaning up the |
|
cc @mridulm |
Since you looked into this - do you have any other thoughts on this @LuciferYang ? Thanks |
no more, the change is fine to me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merged to master. |
@mridulm @LuciferYang Thank you! |
What changes were proposed in this pull request?
This PR propose to simplify the
BlockManager
.Why are the changes needed?
Currently, close or destroy
BlockManager
depend on interrupt thread and the volatile variablestopped
.In fact, we can change the
stopped
to a local variable on stack and let the close operation ofBlockManager
only depend on interrupt thread.For further optimization, this PR using
running
instead ofstopped
.Does this PR introduce any user-facing change?
'No'.
How was this patch tested?
GA tests.
Was this patch authored or co-authored using generative AI tooling?
'No'.