[SPARK-45827] Disallow partitioning on Variant column #44742
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cloud-fan, could you please review, or suggest a reviewer? I'm not sure what the |
cloud-fan
reviewed
Jan 19, 2024
| withTempDir { dir => | ||
| val tempDir = new File(dir, "files").getCanonicalPath | ||
| intercept[AnalysisException] { | ||
| query.write.partitionBy("v").parquet(tempDir) |
There was a problem hiding this comment.
Can we test more cases? e.g. .saveAsTable, and the SQL CTAS.
There was a problem hiding this comment.
Thanks for the review, I added the extra cases to the test.
cloud-fan
approved these changes
Jan 19, 2024
cloud-fan
approved these changes
Jan 19, 2024
|
the failure is unrelated, merging to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Follow-up to #43984: we should not allow partitioning on VariantType. Even though it is is an atomic type, it represents a nested semi-structured value, so not partitioning is consistent with our decision to not allow partitioning on nested types. Also, for now at least, it is not even comparable, so attempting to partition fails with a confusing codegen error about a method named
comparenot being declared.Why are the changes needed?
Improves error message when attempting to partition on Variant, and explicitly forbids a case that we do not intend to support.
Does this PR introduce any user-facing change?
Improved error message if a user tries to partition on Variant.
How was this patch tested?
Added unit test, which fails without the code change.
Was this patch authored or co-authored using generative AI tooling?
No.