[SPARK-46725][SQL] Add DAYNAME function #44758
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PetarVasiljevic-DB
force-pushed
the
function_daytime
branch
from
be611ad
to
fe37595
Compare
PetarVasiljevic-DB
force-pushed
the
function_daytime
branch
from
fe37595
to
11573de
Compare
MaxGekk
reviewed
Jan 17, 2024
There was a problem hiding this comment.
@PetarVasiljevic-DB If it is still draft PR, please, add the [WIP] tag to PR's title, and [SQL] too.
PetarVasiljevic-DB
changed the title
MaxGekk
changed the title
MaxGekk
requested changes
Jan 17, 2024
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/functions.scala
Show resolved
Hide resolved
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
Outdated
Show resolved
Hide resolved
...catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/DateExpressionsSuite.scala
Outdated
Show resolved
Hide resolved
LuciferYang
reviewed
Jan 17, 2024
PetarVasiljevic-DB
force-pushed
the
function_daytime
branch
from
b3382c2
to
22bfe06
Compare
PetarVasiljevic-DB
force-pushed
the
function_daytime
branch
from
22bfe06
to
e7611c9
Compare
MaxGekk
reviewed
Jan 17, 2024
sql/core/src/test/resources/sql-functions/sql-expression-schema.md
Outdated
Show resolved
Hide resolved
MaxGekk
reviewed
Jan 17, 2024
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
Outdated
Show resolved
Hide resolved
Co-authored-by: Maxim Gekk <max.gekk@gmail.com>
PetarVasiljevic-DB
force-pushed
the
function_daytime
branch
2 times, most recently
from
7fa5713
to
2c8f801
Compare
PetarVasiljevic-DB
force-pushed
the
function_daytime
branch
from
2c8f801
to
bbc7fcc
Compare
PetarVasiljevic-DB
changed the title
MaxGekk
reviewed
Jan 20, 2024
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/encoders/ExpressionEncoderSuite.scala
Outdated
Show resolved
Hide resolved
MaxGekk
approved these changes
Jan 21, 2024
|
+1, LGTM. Merging to master. |
|
@PetarVasiljevic-DB Do you have an account at https://issues.apache.org/jira/browse/SPARK-46725? If so, please, leave a comment in the ticket otherwise send an request to create an account for you. |
cloud-fan
reviewed
Jan 24, 2024
| @@ -1105,6 +1105,20 @@ setMethod("monthname", | |||
| column(jc) | |||
| }) | |||
|
|
|||
| #' @details | |||
| #' \code{dayname}: Extracts the three-letter abbreviated day name from a | |||
There was a problem hiding this comment.
I'm fine with the function name DAYNAME, but shall we make it clearer in the doc? day-of-week name instead of day name. This is also what snowflake does: https://docs.snowflake.com/en/sql-reference/functions/dayname
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Added DAYNAME function that returns three letter abbreviation day name for the specified date to:
Why are the changes needed?
For parity with Snowflake
Does this PR introduce any user-facing change?
Yes, since new function DAYNAME is added
How was this patch tested?
Tested on new unit tests
Was this patch authored or co-authored using generative AI tooling?
No