[SPARK-46741][SQL] Cache Table with CTE won't work #44767
+511
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @cloud-fan |
AngersZhuuuu
changed the title
|
How about current? @cloud-fan |
cloud-fan
reviewed
Jan 19, 2024
| _.containsAnyPattern(CTE, PLAN_EXPRESSION)) { | ||
| case ref: CTERelationRef => | ||
| ref.copy(cteId = defIndex(ref.cteId).toLong) | ||
|
|
There was a problem hiding this comment.
can we make sure there is no nested WithCTE?
There was a problem hiding this comment.
can we make sure there is no nested
WithCTE?
Form the CTESubtitution's code, and it's pr, there won't have nested WithCTE. #37751 cc @maryannxue
There was a problem hiding this comment.
shall we add assert to guarantee this assumption?
There was a problem hiding this comment.
@cloud-fan Found nested WithCTE case, added to cte.sql and here change the method to support nested CTE, pls take a look again.
cloud-fan
approved these changes
Jan 19, 2024
cloud-fan
reviewed
Jan 23, 2024
|
ping @cloud-fan @yaooqinn |
|
@cloud-fan Changed follow the discussion |
|
ping @cloud-fan |
1 similar comment
|
ping @cloud-fan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Cache Table with CTE won't work, there are two reasons
Cause the current case can't be matched.
Why are the changes needed?
Fix bug
Does this PR introduce any user-facing change?
Yea, Cache table with CTE can work after this pr
How was this patch tested?
Added UT
Was this patch authored or co-authored using generative AI tooling?
No