-
Notifications
You must be signed in to change notification settings - Fork 28k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-46745][INFRA] Purge pip cache in dockerfile #44768
Conversation
@@ -417,10 +417,6 @@ jobs: | |||
- name: Free up disk space | |||
shell: 'script -q -e -c "bash {0}"' | |||
run: | | |||
if [[ "$MODULES_TO_TEST" != *"pyspark-ml"* ]] && [[ "$BRANCH" != "branch-3.5" ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here doesn't make much sense any more, since we install those libraries for each python version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this will reduce the final status of filesystems.
At the same time, this increases the number of layers, doesn't it?
I'm curious about the download size, @zhengruifeng . Could you check the result of
$ docker images
The size of current PR is 11.1GB
probably we can combine those pip commands to control the number of layers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM. Yes, we can do that later separately.
Merged to master. Thank you, @zhengruifeng and @HyukjinKwon . |
thanks @dongjoon-hyun and @HyukjinKwon for reviews! |
### What changes were proposed in this pull request? Reduce the number of layers of testing dockerfile ### Why are the changes needed? to address #44768 (review) ### Does this PR introduce _any_ user-facing change? no, infra-only ### How was this patch tested? ci ### Was this patch authored or co-authored using generative AI tooling? no Closes #44781 from zhengruifeng/infra_docker_layers. Authored-by: Ruifeng Zheng <ruifengz@apache.org> Signed-off-by: Kent Yao <yao@apache.org>
What changes were proposed in this pull request?
Purge pip cache in dockerfile
Why are the changes needed?
to save 4~5G disk space:
before
https://github.com/zhengruifeng/spark/actions/runs/7541725028/job/20530432798
after
https://github.com/zhengruifeng/spark/actions/runs/7549204209/job/20552796796
Does this PR introduce any user-facing change?
no, infra-only
How was this patch tested?
ci
Was this patch authored or co-authored using generative AI tooling?
no