[SPARK-46811][INFRA] Fix Github Action: TypeError: Cannot read properties of undefined (reading 'head_sha') #44850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ties of undefined (reading 'head_sha')
…ties of undefined (reading 'head_sha')
…ties of undefined (reading 'head_sha')
…ties of undefined (reading 'head_sha')
yaooqinn
changed the title
|
cc @HyukjinKwon, can you help review this |
HyukjinKwon
reviewed
Jan 24, 2024
| await new Promise(resolve => setTimeout(resolve, 3000)); | ||
| } | ||
| } | ||
| if (!check_run_head) { |
There was a problem hiding this comment.
I vaguely remember it's not actually the matter of timeout .. but let's try and see if it makes better.
HyukjinKwon
approved these changes
Jan 24, 2024
|
Merged to master. |
|
If it works, let's also backport this to other brnaches. |
|
Thank you @HyukjinKwon. Let's give it a try |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds a retry for detecting the
Check changesjob and a check for whether it is initialized or not to avoidTypeErrorWhy are the changes needed?
Notify test workflowfails at a high rateDoes this PR introduce any user-facing change?
no
How was this patch tested?
An example PR:
https://github.com/yaooqinn/spark/actions/runs/7624423347/job/20766523539?pr=3
Was this patch authored or co-authored using generative AI tooling?
no